From dc4265884b62199732b33346057388411f85b753 Mon Sep 17 00:00:00 2001 From: zombee0 Date: Thu, 17 Apr 2025 19:26:37 +0800 Subject: [PATCH] [BugFix] use log4j2 as implementation of slf4j (#58005) Signed-off-by: zombee0 --- java-extensions/hadoop-lib/pom.xml | 5 +++ .../utils/loader/ChildFirstClassLoader.java | 4 +- java-extensions/pom.xml | 37 +++++++++++++++++++ 3 files changed, 45 insertions(+), 1 deletion(-) diff --git a/java-extensions/hadoop-lib/pom.xml b/java-extensions/hadoop-lib/pom.xml index ca08e648dd2..53f88bd3853 100644 --- a/java-extensions/hadoop-lib/pom.xml +++ b/java-extensions/hadoop-lib/pom.xml @@ -17,6 +17,11 @@ + + org.apache.logging.log4j + log4j-slf4j-impl + + org.apache.hadoop hadoop-aws diff --git a/java-extensions/java-utils/src/main/java/com/starrocks/utils/loader/ChildFirstClassLoader.java b/java-extensions/java-utils/src/main/java/com/starrocks/utils/loader/ChildFirstClassLoader.java index 7f8cc997e08..0369b9c9659 100644 --- a/java-extensions/java-utils/src/main/java/com/starrocks/utils/loader/ChildFirstClassLoader.java +++ b/java-extensions/java-utils/src/main/java/com/starrocks/utils/loader/ChildFirstClassLoader.java @@ -18,6 +18,7 @@ import java.io.IOException; import java.net.URL; import java.net.URLClassLoader; import java.util.ArrayList; +import java.util.Arrays; import java.util.Collections; import java.util.Enumeration; @@ -38,7 +39,8 @@ public class ChildFirstClassLoader extends URLClassLoader { super(urls, null); this.parentLoader = new ParentClassLoader(parent); // load native method class from parent - this.parentFirstClass = new ArrayList<>(Collections.singleton("com.starrocks.utils.NativeMethodHelper")); + this.parentFirstClass = new ArrayList<>( + Arrays.asList("com.starrocks.utils.NativeMethodHelper", "org.slf4j.ILoggerFactory", "org.slf4j.Logger")); } @Override diff --git a/java-extensions/pom.xml b/java-extensions/pom.xml index 2ec4ab5208e..35c60c24bb6 100644 --- a/java-extensions/pom.xml +++ b/java-extensions/pom.xml @@ -132,6 +132,10 @@ org.apache.zookeeper zookeeper + + org.slf4j + slf4j-reload4j + org.apache.avro avro @@ -185,6 +189,10 @@ com.google.protobuf protobuf-java + + org.slf4j + slf4j-reload4j + @@ -192,6 +200,12 @@ org.apache.hadoop hadoop-kms ${hadoop.version} + + + org.slf4j + slf4j-reload4j + + @@ -204,18 +218,36 @@ org.apache.hadoop hadoop-hdfs-httpfs ${hadoop.version} + + + org.slf4j + slf4j-reload4j + + org.apache.hadoop hadoop-nfs ${hadoop.version} + + + org.slf4j + slf4j-reload4j + + org.apache.hadoop hadoop-hdfs-nfs ${hadoop.version} + + + org.slf4j + slf4j-reload4j + + @@ -295,6 +327,11 @@ log4j-core ${log4j2.version} + + org.apache.logging.log4j + log4j-slf4j-impl + ${log4j2.version} +