tool
/
starrocks
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Tool] Fix check-format.sh script missing files in be/test directory (#24978) 

Signed-off-by: sduzh <zhuming9011@qq.com>
This commit is contained in:
Alex Zhu 2023-06-09 16:11:07 +08:00 committed by GitHub
parent 8618ad43e8
commit acadd8cb9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
be/test/block_cache/block_cache_test.cpp
View File

@ -28,13 +28,9 @@ static const size_t block_size = 1024 * 1024;
class BlockCacheTest : public ::testing::Test {
protected:
static void SetUpTestCase() {
ASSERT_TRUE(fs::create_directories("./ut_dir/block_disk_cache").ok());
}
static void SetUpTestCase() { ASSERT_TRUE(fs::create_directories("./ut_dir/block_disk_cache").ok()); }
static void TearDownTestCase() {
ASSERT_TRUE(fs::remove_all("./ut_dir").ok());
}
static void TearDownTestCase() { ASSERT_TRUE(fs::remove_all("./ut_dir").ok()); }
void SetUp() override {}
void TearDown() override {}

5
build-support/check-format.sh
View File

@ -30,5 +30,8 @@ export STARROCKS_HOME=`cd "${ROOT}/.."; pwd`
CLANG_FORMAT=${CLANG_FORMAT_BINARY:=$(which clang-format)}
python3 ${STARROCKS_HOME}/build-support/run_clang_format.py --clang_format_binary="${CLANG_FORMAT}" --source_dirs="${STARROCKS_HOME}/be/src,${STARROCKS_HOME}/be/test" --quiet
python3 ${STARROCKS_HOME}/build-support/run_clang_format.py --clang_format_binary="${CLANG_FORMAT}" \
--source_dirs="${STARROCKS_HOME}/be/src","${STARROCKS_HOME}/be/test" \
--exclude_globs="${STARROCKS_HOME}/build-support/excludes" --quiet

4
build-support/run_clang_format.py
View File

@ -81,7 +81,6 @@ def _check_dir(arguments, source_dir, exclude_globs):
# if any clang-format reported a parse error, bubble it
returncode, stdout, stderr = res
if returncode != 0:
print(stderr)
sys.exit(returncode)
checker_args.append((filename, stdout))
@ -105,7 +104,8 @@ def _check_dir(arguments, source_dir, exclude_globs):
finally:
pool.terminate()
pool.join()
sys.exit(1 if error else 0)
if error:
sys.exit(1)
if __name__ == "__main__":