tool
/
starrocks
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[BugFix] fix jsonpath rewrite with wrong column type (#63690)

This commit is contained in:
Murphy 2025-09-30 18:37:56 +08:00 committed by GitHub
parent 1a92068146
commit a5da35091a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/JsonPathRewriteRule.java
View File

@ -394,7 +394,9 @@ public class JsonPathRewriteRule extends TransformationRule {
}
private boolean isSupportedJsonFunction(CallOperator call) {
return SUPPORTED_JSON_FUNCTIONS.contains(call.getFnName()) && call.getArguments().size() == 2;
return SUPPORTED_JSON_FUNCTIONS.contains(call.getFnName())
&& call.getArguments().size() == 2
&& call.getChild(0).getType().equals(Type.JSON);
}
private ScalarOperator rewriteJsonFunction(CallOperator call, ScalarOperatorRewriteContext rewriteContext) {

10
fe/fe-core/src/test/java/com/starrocks/sql/plan/JsonPathRewriteTest.java
View File

@ -28,9 +28,11 @@ public class JsonPathRewriteTest extends PlanTestBase {
@BeforeAll
public static void beforeAll() throws Exception {
starRocksAssert.withTable("create table extend_predicate( c1 int, c2 json ) properties('replication_num'='1')");
starRocksAssert.withTable("create table extend_predicate( c1 int, c2 json) properties('replication_num'='1')");
starRocksAssert.withTable("create table extend_predicate2( c1 int, c2 json ) properties" +
"('replication_num'='1')");
starRocksAssert.withTable("create table extend_predicate3( c1 int, c2 string) " +
"properties('replication_num'='1')");
FeConstants.USE_MOCK_DICT_MANAGER = true;
connectContext.getSessionVariable().setEnableLowCardinalityOptimize(true);
@ -212,6 +214,12 @@ public class JsonPathRewriteTest extends PlanTestBase {
" Table: extend_predicate\n" +
" <id 6> : dict_merge_c2.f1\n",
" ExtendedColumnAccessPath: [/c2(varchar)/f1(varchar)]\n"
),
// [21] Test parameter type validation - get_json_string(string, string) should not be rewritten
Arguments.of(
"select get_json_string(c2, 'f1') from extend_predicate3",
"get_json_string(2: c2, 'f1')",
""
)
);
}