tool
/
starrocks
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Refactor] Remove poco_connection_pool_mem_tracker (#63801) 

Signed-off-by: trueeyu <lxhhust350@qq.com>
This commit is contained in:
trueeyu 2025-10-07 15:11:30 +08:00 committed by GitHub
parent fc35890c29
commit a41a7772b4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
be/src/fs/s3/poco_common.cpp
View File

@ -92,7 +92,6 @@ HTTPSessionPtr makeHTTPSessionImpl(const std::string& host, Poco::UInt16 port, b
}
EndpointHTTPSessionPool::Base::ObjectPtr EndpointHTTPSessionPool::allocObject() {
SCOPED_THREAD_LOCAL_MEM_TRACKER_SETTER(_mem_tracker);
auto session = makeHTTPSessionImpl(_host, _port, _is_https, true);
return session;
}

5
be/src/fs/s3/poco_common.h
View File

@ -68,9 +68,7 @@ class EndpointHTTPSessionPool : public PoolBase<Poco::Net::HTTPClientSession> {
public:
using Base = PoolBase<Poco::Net::HTTPClientSession>;
EndpointHTTPSessionPool(std::string host, uint16_t port, bool is_https)
: Base(ENDPOINT_POOL_SIZE), _host(std::move(host)), _port(port), _is_https(is_https) {
_mem_tracker = GlobalEnv::GetInstance()->poco_connection_pool_mem_tracker();
}
: Base(ENDPOINT_POOL_SIZE), _host(std::move(host)), _port(port), _is_https(is_https) {}
private:
ObjectPtr allocObject() override;
@ -80,7 +78,6 @@ private:
const std::string _host;
const uint16_t _port;
const bool _is_https;
MemTracker* _mem_tracker = nullptr;
};
class HTTPSessionPools {

1
be/src/runtime/exec_env.cpp
View File

@ -241,7 +241,6 @@ Status GlobalEnv::_init_mem_tracker() {
_consistency_mem_tracker =
regist_tracker(MemTrackerType::CONSISTENCY, consistency_mem_limit, process_mem_tracker());
_datacache_mem_tracker = regist_tracker(MemTrackerType::DATACACHE, -1, process_mem_tracker());
_poco_connection_pool_mem_tracker = regist_tracker(MemTrackerType::POCO_CONNECTION_POOL, -1, process_mem_tracker());
_replication_mem_tracker = regist_tracker(MemTrackerType::REPLICATION, -1, process_mem_tracker());
MemChunkAllocator::init_metrics();

4
be/src/runtime/exec_env.h
View File

@ -160,7 +160,6 @@ public:
MemTracker* consistency_mem_tracker() { return _consistency_mem_tracker.get(); }
MemTracker* replication_mem_tracker() { return _replication_mem_tracker.get(); }
MemTracker* datacache_mem_tracker() { return _datacache_mem_tracker.get(); }
MemTracker* poco_connection_pool_mem_tracker() { return _poco_connection_pool_mem_tracker.get(); }
MemTracker* jemalloc_metadata_traker() { return _jemalloc_metadata_tracker.get(); }
std::shared_ptr<MemTracker> get_mem_tracker_by_type(MemTrackerType type);
std::vector<std::shared_ptr<MemTracker>> mem_trackers() const;
@ -235,9 +234,6 @@ private:
// The memory used for datacache
std::shared_ptr<MemTracker> _datacache_mem_tracker;
// The memory used for poco connection pool
std::shared_ptr<MemTracker> _poco_connection_pool_mem_tracker;
std::map<MemTrackerType, std::shared_ptr<MemTracker>> _mem_tracker_map;
};

1
be/src/runtime/mem_tracker.cpp
View File

@ -72,7 +72,6 @@ static std::vector<std::pair<MemTrackerType, std::string>> s_mem_types = {
{MemTrackerType::UPDATE, "update"},
{MemTrackerType::CLONE, "clone"},
{MemTrackerType::DATACACHE, "datacache"},
{MemTrackerType::POCO_CONNECTION_POOL, "poco_connection_pool"},
{MemTrackerType::REPLICATION, "replication"},
{MemTrackerType::ROWSET_UPDATE_STATE, "rowset_update_state"},
{MemTrackerType::INDEX_CACHE, "index_cache"},

1
be/src/runtime/mem_tracker.h
View File

@ -111,7 +111,6 @@ enum class MemTrackerType {
UPDATE,
CLONE,
DATACACHE,
POCO_CONNECTION_POOL,
REPLICATION,
ROWSET_UPDATE_STATE,
INDEX_CACHE,