tool
/
sshfs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sftp_readdir_async(): don't access request when it may have been freed 

Fixes: #7
This commit is contained in:
Nikolaus Rath 2017-07-12 16:43:23 +02:00
parent 6f6491cd13
commit 82766d1093
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog.rst
View File

@ -1,3 +1,9 @@
Unreleased Changes
------------------
* Fixed a crash due to a race condition when listing
directory contents.
Release 3.0.0 (2017-07-08)
--------------------------

7
sshfs.c
View File

@ -2073,11 +2073,16 @@ static int sftp_readdir_async(struct buffer *handle, void *buf, off_t offset,
outstanding--;
if (done) {
/* We need to cache want_reply, since processing
thread may free req right after unlock() if
want_reply == 0 */
int want_reply;
pthread_mutex_lock(&sshfs.lock);
if (sshfs_req_pending(req))
req->want_reply = 0;
want_reply = req->want_reply;
pthread_mutex_unlock(&sshfs.lock);
if (!req->want_reply)
if (!want_reply)
continue;
}